-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experimental: RPA documentation #4440
experimental: RPA documentation #4440
Conversation
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
@marstamm Is this meant to go into the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback on the addition (some meta-feedback inside) ⏬
Add relevant links (i.e. link to the components from the description for easier access):
Do not make the "Robottic Process Automation" navigation entry a dead link. Instead, as I click on it I end up on the page describing it. Remove on of the sub-pages. Consider to call the page "RPA integration" (it should be clear that this is with Camunda).
See Desktop Modeler and some other pages that already have a proper navigation structure (where clicking a section leads to actual content, not just opens it in the navigation):
This does not seem to be properly formatted (the numbered list is part of the second bullet point):
Borders / padding around screenshots look odd, remove them:
Consider to link back to the "landing page" for RPA, to provide further context from the RPA framework library page:
Does not make sense to me:
I propose we make {variableName}
verbatime (code) syntax here, as it references a technical idenfifier (in the above script):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments with small improvements, nothing major from my side :)
docs/components/experimental/rpa/camunda-rpa-framework-library.md
Outdated
Show resolved
Hide resolved
docs/components/experimental/rpa/rpa-integration-with-camunda.md
Outdated
Show resolved
Hide resolved
docs/components/experimental/rpa/camunda-rpa-framework-library.md
Outdated
Show resolved
Hide resolved
docs/components/experimental/rpa/camunda-rpa-framework-library.md
Outdated
Show resolved
Hide resolved
docs/components/experimental/rpa/camunda-rpa-framework-library.md
Outdated
Show resolved
Hide resolved
docs/components/experimental/rpa/camunda-rpa-framework-library.md
Outdated
Show resolved
Hide resolved
I have resolved all lingering comments @marstamm -- let me know how this looks to you 👍 |
@mesellings Looping you in for review as most other folks are out today 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, just some non-blocking suggestions, but I know you want this out of the door for NY, so approving for you 👍
docs/components/experimental/rpa/rpa-integration-with-camunda.md
Outdated
Show resolved
Hide resolved
docs/components/experimental/rpa/rpa-integration-with-camunda.md
Outdated
Show resolved
Hide resolved
docs/components/experimental/rpa/rpa-integration-with-camunda.md
Outdated
Show resolved
Hide resolved
docs/components/experimental/rpa/rpa-integration-with-camunda.md
Outdated
Show resolved
Hide resolved
docs/components/experimental/rpa/rpa-integration-with-camunda.md
Outdated
Show resolved
Hide resolved
docs/components/experimental/rpa/camunda-rpa-framework-library.md
Outdated
Show resolved
Hide resolved
docs/components/experimental/rpa/camunda-rpa-framework-library.md
Outdated
Show resolved
Hide resolved
docs/components/experimental/rpa/camunda-rpa-framework-library.md
Outdated
Show resolved
Hide resolved
docs/components/experimental/rpa/camunda-rpa-framework-library.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Mark Sellings <[email protected]>
Co-authored-by: Mark Sellings <[email protected]>
Co-authored-by: Mark Sellings <[email protected]>
Co-authored-by: Mark Sellings <[email protected]>
Co-authored-by: Mark Sellings <[email protected]>
Co-authored-by: Mark Sellings <[email protected]>
Co-authored-by: Mark Sellings <[email protected]>
Co-authored-by: Mark Sellings <[email protected]>
Co-authored-by: Mark Sellings <[email protected]>
The preview environment relating to the commit 1644354 has successfully been deployed. You can access it at https://preview.docs.camunda.cloud/pr-4440/index.html |
* initial 4 feature structure * adjust sidebar behavior * update overview * update sidebar * update sidebar * experimental: RPA documentation (#4440) * add rpa documentation * tidy typo * resolve comments * adjust sidebar * add to sidebar * update link * resolve comments * Update docs/components/experimental/rpa/rpa-integration-with-camunda.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/experimental/rpa/rpa-integration-with-camunda.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/experimental/rpa/rpa-integration-with-camunda.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/experimental/rpa/camunda-rpa-framework-library.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/experimental/rpa/camunda-rpa-framework-library.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/experimental/rpa/camunda-rpa-framework-library.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/experimental/rpa/camunda-rpa-framework-library.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/experimental/rpa/rpa-integration-with-camunda.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/experimental/rpa/rpa-integration-with-camunda.md Co-authored-by: Mark Sellings <[email protected]> --------- Co-authored-by: Mark Sellings <[email protected]> * incorporate rpa docs into sidebar * fix broken link * update img path * update image path * experimental: SAP documentation (#4267) * initial poc commit * wip: sap odata connector * wip: further docs * docs: spell check * feat: first draft of the sap docs * initial edits * revise rfc connector * remove from sidebar for now * Update docs/guides/sap/btp-integration.md Co-authored-by: Cole Isaac <[email protected]> * Update docs/guides/sap/camunda-sap-integration.md Co-authored-by: Cole Isaac <[email protected]> * Update docs/guides/sap/rfc-connector.md Co-authored-by: Cole Isaac <[email protected]> * resolve comments * second review of sap content * fix link * resolve comments * move into components for now * Update docs/components/sap/odata-connector.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/sap/odata-connector.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/sap/odata-connector.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/sap/rfc-connector.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/sap/rfc-connector.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/sap/rfc-connector.md Co-authored-by: Mark Sellings <[email protected]> --------- Co-authored-by: Volker Buzek <[email protected]> Co-authored-by: Volker Buzek <[email protected]> Co-authored-by: Volker Buzek <[email protected]> Co-authored-by: Christina Ausley <[email protected]> Co-authored-by: christinaausley <[email protected]> Co-authored-by: Cole Isaac <[email protected]> Co-authored-by: Mark Sellings <[email protected]> * incorporate sap docs * fix broken link * minor tweak * resolve comments * typo --------- Co-authored-by: christinaausley <[email protected]> Co-authored-by: Christina Ausley <[email protected]> Co-authored-by: Mark Sellings <[email protected]> Co-authored-by: Volker Buzek <[email protected]> Co-authored-by: Volker Buzek <[email protected]> Co-authored-by: Volker Buzek <[email protected]> Co-authored-by: Cole Isaac <[email protected]>
Description
Relates to https://github.com/camunda/product-hub/issues/2412.
Incorporates RPA documentation into experimental features.
When should this change go live?
hold
label or convert to draft PR) CConPR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).